Hello again,
This week I started with fixing a crash in LightweightEQ, which is an Equalizer Effect for low-performance hardware. The problem was the id's of the effect parameters, they were not correctly set. So I have fixed that by assigning the following ids for the knobs: “eq_low”, “eq_mid” and “eq_high”. On top of that, I removed dry mixing both from LightweightEQ and EQDefault. However, I talked with Daniel and we plan to reintroduce that to the effect which uses Bessel filters.
I am happy to inform you that I'm making progress towards my goal of replacing the Default EQ from enginefilterblock.cpp with an Equalizer Effect. I have finally managed to add switch type parameters to the Effects framework. The last bug was a typo Daniel pointed me out in effectbuttonparameterslot.cpp. I was calling getParameter() method instead of getButtonParameter() inside loadEffect(). Prior to fixing this, the buttons were not updating correctly, they were dependent to their corresponding knob. All they need now is a bit of code refactoring, because some code is duplicated, especially in effectbuttonparameterslot.cpp which contains the class for handling Button parameters.
For the EQ Effect Rack I broken down my work in the following parts:
You can see my work on the EQ EffectRack and switch type parameters here[2].
Yours truly,
Nicu Badescu
[1] - https://bugs.launchpad.net/mixxx/+bug/1273953
[2] - https://github.com/badescunicu/mixxx/compare/kill_buttons